[Vortex] Proper typing of $this->class in unit tests

Review Request #1050 — Created Oct. 31, 2023 and submitted Oct. 31, 2023, 6:44 p.m.

Information
Owner:	pprkut
Repository:	Lunr.Vortex
Branch:
Bugs:
Depends On:
Commit:	3f36008...
Reviewers
Groups:	lunr
People:

Description

Proper typing of $this->class in unit tests

Testing Done

GitHub actions run: https://github.com/pprkut/lunr.vortex/actions/runs/6706992834

Issues

0
0
0
2
All Issues: 2

Description	From	Last Updated
It seems a bit redundant to set $this->class twice, here and again in parent::baseSetUp	b.stoop	Oct. 31, 2023, 4:51 p.m.
$this->class is also unset in the parent::tearDown	b.stoop	Oct. 31, 2023, 4:51 p.m.

src/Lunr/Vortex/APNS/ApnsPHP/Tests/APNSDispatcherTest.php (Diff revision 1)

Show all issues

It seems a bit redundant to set $this->class twice, here and again in parent::baseSetUp

pprkut Oct. 31, 2023, 4:29 p.m.

I know, but that's how PHP's typing works. The parent class is private and of type object. The local class is a separate variable from the parent private one, and has type APNSDispatcher&MockObject.

The parent must be private, otherwise there can't be two separate types. You can also see some more discussion in the Halo review: https://reviews.lunr.nl/r/1044/

src/Lunr/Vortex/APNS/ApnsPHP/Tests/APNSDispatcherTest.php (Diff revision 1)
Show all issues
```
$this->class is also unset in the parent::tearDown
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (ddf435f)

You have a pending review.

Review Board 3.0.24

[Vortex] Proper typing of $this->class in unit tests

Status: Closed (submitted)

Change Summary: