[Halo] Proper typing of $this->class

Review Request #1044 — Created Oct. 22, 2023 and submitted

Information
pprkut
Lunr.Halo
05205df...
Reviewers
lunr 
This is a major API break, as any (main) test class extending
LunrBaseTest will need to be adjusted for this.
GitHub actions run: https://github.com/pprkut/lunr.halo/actions/runs/6605746554
  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
There are no open issues
smillernl
smillernl 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    The issue has been dropped.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    maybe we keep the protection level at first and convert to the baseSetUp only?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Properties need to be covariant and contravariant. Meaning, they must always have the same type. If we keep it protected, we can't change the type in the subclasses and it would need to be object everywhere (or mixed). It wouldn't save us anything. We'd first have to change all test classes to use baseSetUp() and then change all test classes again to fix the typing.
      
 
      

      2. 


 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




smillernl




   

   







  

 



 

  


   

   

    
 
smillernl


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




pprkut




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (bee324a)





 


 










  

 









     

    

   

  

  

   
   Loading...