[Halo] Proper typing of $this->class

Review Request #1044 — Created Oct. 22, 2023 and submitted Oct. 30, 2023, 4:43 p.m.

Information
Owner:	pprkut
Repository:	Lunr.Halo
Branch:
Bugs:
Depends On:
Commit:	05205df...
Reviewers
Groups:	lunr
People:

Description

This is a major API break, as any (main) test class extending
LunrBaseTest will need to be adjusted for this.

Testing Done

GitHub actions run: https://github.com/pprkut/lunr.halo/actions/runs/6605746554

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
maybe we keep the protection level at first and convert to the baseSetUp only?	smillernl	Oct. 26, 2023, 10:31 a.m.

Show all issues

maybe we keep the protection level at first and convert to the baseSetUp only?

pprkut Oct. 23, 2023, 10:17 a.m.

Properties need to be covariant and contravariant. Meaning, they must always have the same type. If we keep it protected, we can't change the type in the subclasses and it would need to be object everywhere (or mixed). It wouldn't save us anything. We'd first have to change all test classes to use baseSetUp() and then change all test classes again to fix the typing.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (bee324a)

You have a pending review.

Review Board 3.0.24

[Halo] Proper typing of $this->class

Status: Closed (submitted)

Change Summary: