-
-
src/Lunr/Gravity/MySQL/MySQLConnection.php (Diff revision 1) Need error handling here, and potentially a dedicated exception
-
src/Lunr/Gravity/SQLite3/SQLite3Connection.php (Diff revision 1) defragment works differently for sqlite
-
-
src/Lunr/Gravity/MySQL/MySQLConnection.php (Diff revisions 1 - 2) The preg_match is not needed. Just use the escaper.
-
src/Lunr/Gravity/MySQL/MySQLConnection.php (Diff revisions 1 - 2) I'd probably go for
DefragmentationException
, since "optimize" is a very mysql specific term. -
src/Lunr/Gravity/SQLite3/SQLite3Connection.php (Diff revisions 1 - 2) This should be
?string
, only here, not in the parent. -
src/Lunr/Gravity/SQLite3/SQLite3Connection.php (Diff revisions 1 - 2) That's the query for when
$table
isNULL
Diff: |
Revision 3 (+301)
|
---|
-
-
src/Lunr/Gravity/MySQL/MySQLConnection.php (Diff revision 3) i can't find where this is used,
is it needed?
-
-
src/Lunr/Gravity/MySQL/Tests/MySQLConnectionDefragmentTest.php (Diff revision 3) missing description and @covers
i don't think that is the position we usually use for @param and @dataProvider -
-
-
src/Lunr/Gravity/SQLite3/Tests/SQLite3ConnectionDefragmentTest.php (Diff revision 3) missing @covers
-
-
-
src/Lunr/Gravity/Exceptions/DefragmentationException.php (Diff revision 3) It can't the file is created in 2023
-
-
src/Lunr/Gravity/SQLite3/Tests/SQLite3ConnectionDefragmentTest.php (Diff revision 3) No, the file is too new for that.
Diff: |
Revision 4 (+303)
|
---|
-
-
src/Lunr/Gravity/MySQL/MySQLConnection.php (Diff revision 4) This doesn't actually tell us why the query failed. We do this with the logger in the
DatabaseAccessObject
-
src/Lunr/Gravity/MySQL/Tests/MySQLConnectionDefragmentTest.php (Diff revision 4) Nothing in the
defragment
method checks for valid table names. -
src/Lunr/Gravity/MySQL/Tests/MySQLConnectionDefragmentTest.php (Diff revision 4) If we don't care about the return of the method, there's no need to mock it.
-
src/Lunr/Gravity/MySQL/Tests/MySQLConnectionDefragmentTest.php (Diff revision 4) Don't really care about this here. Changing the logging in the query method shouldn't cause this test to fail
-
Diff: |
Revision 5 (+240)
|
---|
Diff: |
Revision 6 (+237 -4)
|
---|
-
-
src/Lunr/Gravity/DatabaseConnection.php (Diff revision 6) This shouldn't be removed for existing files
-
src/Lunr/Gravity/SQLite3/SQLite3Connection.php (Diff revision 6) Probably good to log that passing a
$table
did nothing here. -
src/Lunr/Gravity/SQLite3/SQLite3Connection.php (Diff revision 6) Shouldn't this represent the table too?
Diff: |
Revision 7 (+239 -1)
|
---|
-
-
src/Lunr/Gravity/SQLite3/SQLite3Connection.php (Diff revision 7) The default will never be used since the parent method does not allow null.
-
Diff: |
Revision 8 (+237)
|
---|
-
-
src/Lunr/Gravity/SQLite3/SQLite3Connection.php (Diff revision 8) Let's just make it like:
* @param string $table This parameter is ignored when using SQLite, as VACUUM operates on the entire database.
-
-
src/Lunr/Gravity/MySQL/Tests/MySQLConnectionDefragmentTest.php (Diff revision 8) We know the complete message here so no need to do a substring only match
-
src/Lunr/Gravity/SQLite3/SQLite3Connection.php (Diff revision 8) We can come up with a better error message here. Don't need to end the string with
:
;)
Diff: |
Revision 9 (+236)
|
---|