[L10n] Fix phpstan issues

Review Request #1005 — Created July 8, 2023 and submitted

Information
pprkut
Lunr
97c7d66...
Reviewers
lunr 
Fix phpstan issues
GitHub actions run: https://github.com/pprkut/lunr/actions/runs/5493956990
  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
There are no open issues
smillernl
smillernl 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      src/Lunr/L10n/L10n.php
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    The issue has been dropped.
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    array|null right? And can we add it as a property type?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      This worked fine for me. I only needed |null in one place to work around an apparant incompatibility between phpstan and phpcs.
      
I'm not doing property types here just yet. I want to do the update to 8.1 first
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Yeah, I think it might just be my IDE. I'll drop this.
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




smillernl




   

   







  

 



 

  


   

   

    
 
smillernl


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




pprkut




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (a723eb2)





 


 










  

 









     

    

   

  

  

   
   Loading...