Summary:

[DataAccess] Added DELETE functionality to query builders

Review Request #1 — Created Oct. 24, 2012 and submitted Nov. 1, 2012, 6:33 p.m.

Information
Owner:	Felipe
Repository:	Lunr
Branch:	https://github.com/pprkut/lunr/tree/select
Bugs:
Depends On:
Reviewers
Groups:
People:	pprkut

Description

Added DELETE functionality to query builders

Get it here: https://github.com/madsmash/lunr/commits/delete

Testing Done

Unit tests

Issues

Description	From	Last Updated
Please add yourself as author	pprkut	Oct. 24, 2012, 7:01 p.m.
the tables to delete from deleting the table would be "DROP TABLE" ;)	pprkut	Oct. 24, 2012, 7:02 p.m.
s/select/delete/	pprkut	Oct. 24, 2012, 7:03 p.m.
again, delete from	pprkut	Oct. 24, 2012, 7:03 p.m.
author	pprkut	Oct. 24, 2012, 7:03 p.m.
author	pprkut	Oct. 24, 2012, 7:04 p.m.
missing copyright and license	pprkut	Oct. 24, 2012, 7:05 p.m.
wrong test name	pprkut	Oct. 24, 2012, 7:07 p.m.
Drop M2Mobi as author	pprkut	Oct. 24, 2012, 7:05 p.m.
incomplete explanation	pprkut	Oct. 24, 2012, 7:07 p.m.
Same as in the previous file	pprkut	Oct. 24, 2012, 7:09 p.m.
Please add yourself as author	pprkut	Nov. 1, 2012, 6:20 p.m.

Checked with the Reviewboard documentation.
"Branch" should list the branch your changes are based on

-	https://github.com/madsmash/lunr/tree/delete
+	https://github.com/pprkut/lunr/tree/select

tests/system/libraries/dataaccess/class.databasedmlquerybuilder.queryparts.delete.test.php (Diff revision 1)

Show all issues

missing copyright and license

tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.delete.test.php (Diff revision 1)

Show all issues

Same as in the previous file

Fixed all issues reported so far

	system/libraries/dataaccess/class.databasedmlquerybuilder.inc.php
	system/libraries/dataaccess/class.mysqldmlquerybuilder.inc.php
	tests/phpunit.xml
	tests/system/libraries/dataaccess/class.databasedmlquerybuilder.base.test.php
	tests/system/libraries/dataaccess/class.databasedmlquerybuilder.queryparts.delete.test.php
	tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.delete.test.php
	tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.test.php

		Added DELETE functionality to query builders
	+
	+	Get it here: https://github.com/madsmash/lunr/commits/delete

tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.test.php (Diff revision 2)

Show all issues

Please add yourself as author

Added author missing in test file

	system/libraries/dataaccess/class.databasedmlquerybuilder.inc.php
	system/libraries/dataaccess/class.mysqldmlquerybuilder.inc.php
	tests/phpunit.xml
	tests/system/libraries/dataaccess/class.databasedmlquerybuilder.base.test.php
	tests/system/libraries/dataaccess/class.databasedmlquerybuilder.queryparts.delete.test.php
	tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.delete.test.php
	tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.test.php

Merged into master

You have a pending review.