This change has been marked as submitted.

Describe the submission (optional):

Merged into master

Reviews
Diff

- Download Diff

Summary:

[DataAccess] Added DELETE functionality to query builders

Review Request #1 — Created Oct. 24, 2012 and submitted 12 years, 6 months ago

Information
Owner:	Felipe*
Repository:	Lunr
Branch:	https://github.com/pprkut/lunr/tree/select
Bugs:
Depends On:
Reviewers
Groups:
People:	pprkut

Description

Added DELETE functionality to query builders

Get it here: https://github.com/madsmash/lunr/commits/delete

Testing Done

Unit tests

Issues

0
0
12
0
All Issues: 12

Description	From	Last Updated
Please add yourself as author	pprkut	12 years, 6 months ago
the tables to delete from deleting the table would be "DROP TABLE" ;)	pprkut	12 years, 6 months ago
s/select/delete/	pprkut	12 years, 6 months ago
again, delete from	pprkut	12 years, 6 months ago
author	pprkut	12 years, 6 months ago
author	pprkut	12 years, 6 months ago
missing copyright and license	pprkut	12 years, 6 months ago
wrong test name	pprkut	12 years, 6 months ago
Drop M2Mobi as author	pprkut	12 years, 6 months ago
incomplete explanation	pprkut	12 years, 6 months ago
Same as in the previous file	pprkut	12 years, 6 months ago
Please add yourself as author	pprkut	12 years, 6 months ago
There are no open issues

Change Summary:

Checked with the Reviewboard documentation.
"Branch" should list the branch your changes are based on

Branch:

-	https://github.com/madsmash/lunr/tree/delete
+	https://github.com/pprkut/lunr/tree/select

system/libraries/dataaccess/class.databasedmlquerybuilder.inc.php (Diff revision 1)
The issue has been resolved. Show all issues
```
Please add yourself as author
```
system/libraries/dataaccess/class.databasedmlquerybuilder.inc.php (Diff revision 1)
The issue has been resolved. Show all issues
```
the tables to delete *from*

deleting the table would be "DROP TABLE" ;)
```
system/libraries/dataaccess/class.databasedmlquerybuilder.inc.php (Diff revision 1)
The issue has been resolved. Show all issues
```
s/select/delete/
```
system/libraries/dataaccess/class.databasedmlquerybuilder.inc.php (Diff revision 1)
The issue has been resolved. Show all issues
```
again, delete *from*
```
system/libraries/dataaccess/class.mysqldmlquerybuilder.inc.php (Diff revision 1)
The issue has been resolved. Show all issues
```
author
```
system/libraries/dataaccess/class.mysqldmlquerybuilder.inc.php (Diff revision 1)
```
Yay :)
```
tests/system/libraries/dataaccess/class.databasedmlquerybuilder.base.test.php (Diff revision 1)
The issue has been resolved. Show all issues
```
author
```

tests/system/libraries/dataaccess/class.databasedmlquerybuilder.queryparts.delete.test.php (Diff revision 1)

The issue has been resolved. Show all issues

missing copyright and license

tests/system/libraries/dataaccess/class.databasedmlquerybuilder.queryparts.delete.test.php (Diff revision 1)
The issue has been resolved. Show all issues
```
wrong test name
```
tests/system/libraries/dataaccess/class.databasedmlquerybuilder.queryparts.delete.test.php (Diff revision 1)
The issue has been resolved. Show all issues
```
Drop M2Mobi as author
```
tests/system/libraries/dataaccess/class.databasedmlquerybuilder.queryparts.delete.test.php (Diff revision 1)
The issue has been resolved. Show all issues
```
incomplete explanation
```

tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.delete.test.php (Diff revision 1)

The issue has been resolved. Show all issues

Same as in the previous file

Change Summary:

Fixed all issues reported so far

Diff:

Revision 2 (+502 -1)

Show changes

	system/libraries/dataaccess/class.databasedmlquerybuilder.inc.php
	system/libraries/dataaccess/class.mysqldmlquerybuilder.inc.php
	tests/phpunit.xml
	tests/system/libraries/dataaccess/class.databasedmlquerybuilder.base.test.php
	tests/system/libraries/dataaccess/class.databasedmlquerybuilder.queryparts.delete.test.php
	tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.delete.test.php
	tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.test.php

Description:

		Added DELETE functionality to query builders
	+
	+	Get it here: https://github.com/madsmash/lunr/commits/delete

tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.test.php (Diff revision 2)

The issue has been resolved. Show all issues

Please add yourself as author

Change Summary:

Added author missing in test file

Diff:

Revision 3 (+503 -1)

Show changes

	system/libraries/dataaccess/class.databasedmlquerybuilder.inc.php
	system/libraries/dataaccess/class.mysqldmlquerybuilder.inc.php
	tests/phpunit.xml
	tests/system/libraries/dataaccess/class.databasedmlquerybuilder.base.test.php
	tests/system/libraries/dataaccess/class.databasedmlquerybuilder.queryparts.delete.test.php
	tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.delete.test.php
	tests/system/libraries/dataaccess/class.mysqldmlquerybuilder.test.php

Status: Closed (submitted)

Change Summary:

Merged into master

You have a pending review.

Review Board 3.0.24

This change has been marked as submitted.

[DataAccess] Added DELETE functionality to query builders

Change Summary:

Branch:

Change Summary:

Diff:

Description:

Change Summary:

Diff:

Status: Closed (submitted)

Change Summary: